Skip to content

[codex] Try removing Cog URL workaround#101

Draft
nelsonjchen wants to merge 2 commits intomasterfrom
codex/plan-issue-2868-check
Draft

[codex] Try removing Cog URL workaround#101
nelsonjchen wants to merge 2 commits intomasterfrom
codex/plan-issue-2868-check

Conversation

@nelsonjchen
Copy link
Copy Markdown
Owner

What changed

This branch tries to remove the repo-local Cog URL workaround stack and simplify the workflow back to stock Cog behavior.

It:

  • removes literal: acceptance from route validation and the related tests
  • updates local cog predict examples to use raw https://connect.comma.ai/... URLs
  • deletes the old cog/runtime_patch/ builder and its Makefile/docs wiring
  • rewrites the deploy and readiness docs around stock Cog 0.17.1+

Why

This was prompted by the upstream follow-up on replicate/cog#2868 and local confirmation that stock Cog 0.17.1 appears to pass raw URL strings correctly in some paths.

Impact

If this branch were merged as-is, the repo would stop accepting the legacy literal: wrapper and would assume that current stock Cog handles the route URL path correctly.

Root cause / blocker

This PR is still draft because the Linux GPU path is not fully explained yet.

What I confirmed:

  • local macOS cog 0.17.1 raw-URL predict succeeded for this repo
  • an isolated throwaway predictor on GCE with stock Linux cog 0.17.1 also passed a plain str URL through unchanged

What is still failing:

  • on the GCE nvidia-l4 VM, this repo's stock cog 0.17.1 smoke still fails because the predictor receives the route as a temp-file path instead of the original URL string
  • the observed failure payload on the VM was:
    • raw_type=Path
    • raw_repr=Path('/tmp/tmpc6ososx7105')

So this branch is useful as an investigation checkpoint, but it is not merge-ready yet.

Checks

  • uv run pytest tests/test_replicate_run.py
  • local macOS smoke with stock cog 0.17.1
  • GCE nvidia-l4 smoke with stock cog 0.17.1 on the repo predictor
  • isolated GCE throwaway predictor smoke with stock cog 0.17.1

Notes

  • rebased onto current master
  • stopped the temporary GCE VM after testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant