Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This branch tries to remove the repo-local Cog URL workaround stack and simplify the workflow back to stock Cog behavior.
It:
literal:acceptance from route validation and the related testscog predictexamples to use rawhttps://connect.comma.ai/...URLscog/runtime_patch/builder and its Makefile/docs wiring0.17.1+Why
This was prompted by the upstream follow-up on
replicate/cog#2868and local confirmation that stock Cog0.17.1appears to pass raw URL strings correctly in some paths.Impact
If this branch were merged as-is, the repo would stop accepting the legacy
literal:wrapper and would assume that current stock Cog handles the route URL path correctly.Root cause / blocker
This PR is still draft because the Linux GPU path is not fully explained yet.
What I confirmed:
cog 0.17.1raw-URL predict succeeded for this repocog 0.17.1also passed a plainstrURL through unchangedWhat is still failing:
nvidia-l4VM, this repo's stockcog 0.17.1smoke still fails because the predictor receives the route as a temp-file path instead of the original URL stringraw_type=Pathraw_repr=Path('/tmp/tmpc6ososx7105')So this branch is useful as an investigation checkpoint, but it is not merge-ready yet.
Checks
uv run pytest tests/test_replicate_run.pycog 0.17.1nvidia-l4smoke with stockcog 0.17.1on the repo predictorcog 0.17.1Notes
master