Repository navigation
fix registry listing and entity schema scoping - #1
Merged
ndamania00 merged 1 commit intoNov 3, 2026
Merged
ndamania00 merged 1 commit into
ndamania00 merged 1 commit into
Conversation
- list registries from /api/v3/registry/items, without the archived filter that endpoint rejects - entity schema records carry an organization but no registry, so is_in_registry_scope falls back to the registry's organization - check for ambiguous registries only when use_api is set - check registry_id against the registry list on single-registry tenants - tests use record shapes that match the v3 API, and check the registry list request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes for dynotx#274, found testing against a tenant with six registries.
/api/v3/registry/items. That endpoint rejects thearchivedfilter, solist_all_items_v3can now skip it by passinginclude_archived=None.organizationbut noregistry, sois_in_registry_scopefalls back to the registry's organization. Before this, every entity schema was filtered out.use_api=False. The ambiguity check in__init__runs only when the API is set up.registry_idon a one-registry tenant. It's now checked against the registry list, so a wrong id raises instead of being ignored./api/v3/registry/items, and a test checks that the request has noarchivedfilter. There are new tests for the two edge cases. 33 pass, and 7 of them fail without these changes.Live, on six registries: Sandbox and another registry diff clean, a
generate-filesround trip is clean, and creating a dropdown and a schema puts them in the chosen registry and its organization. On a one-registry tenant, diffs match the current behaviour.