Migrate to Kotlin DSL and update AGP to align with 16kb page sizes#2
Open
engdyn wants to merge 2 commits into
Open
Migrate to Kotlin DSL and update AGP to align with 16kb page sizes#2engdyn wants to merge 2 commits into
engdyn wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey Naveen,
I noticed that the FossifyGallery doesn't align with 16kb page sizes due to this library just as the person from the other open PR. Instead of just adding a specific NDK version to the build.gradle I decided to update the whole thing.
I migrated the project to Kotlin DSL and removed redundant stuff from the build scripts and all deprecated options that will be removed with Gradle 10. I bumped the AGP and fixed the broken alignment in the example app due to how higher SDKs interact with the notch. Updating the AGP automatically updates the NDK and the .so files are now 16kb aligned. I bumped the minSdk to 26 because that's what FossifyGallery uses.