Upgrade Android NDK to align with 16kb page sizes#1
Open
gmasil wants to merge 1 commit into
Open
Conversation
Author
|
@naveensingh any thoughts? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Naveen,
I noticed that the FossifyGallery doesn't align with 16kb page sizes as recommended, see https://developer.android.com/guide/practices/page-sizes.
In my personal fork I included ffmpeg-kit binaries and was just able to comply with the 16kb alignments in all native binaries. This library just needed an upgrade to the latest Android NDK to automatically enable the alignment.
Please let me know what you think,
Simon