Skip to content

Fix data race on ConcurrencySlot::in_use - #398

Open
GeorgJohn wants to merge 1 commit into
ros2from
fix/in_use_data_race
Open

GeorgJohn wants to merge 1 commit into
ros2from
fix/in_use_data_race

Conversation

@GeorgJohn

Copy link
Copy Markdown
Contributor

Solves issue #395

  • Because std::atomic can't be copied, new slots are now created with concurrency_slots_.try_emplace(slot_id) instead of insert(std::make_pair(...)).
  • This commit also reformats abstract_action_base.hpp to ROS 2 style. This changes no behavior.

@GeorgJohn
GeorgJohn requested a review from amock October 20, 2026 15:41
@GeorgJohn GeorgJohn self-assigned this Oct 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Data race on ConcurrencySlot::in_use when an action worker finishes

1 participant