Repository navigation
Report ci / Fast as taskgraph Required's real result - #228
Merged
Merged
Conversation
Callers whose ruleset still requires ci / Fast keep that context while the gate is ci / Required. The alias needs Required, runs under always(), and fails unless Required succeeded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
taskgraph.ymlgains aFastjob that needsrequired, runs underalways(), and exits 1 unlessrequiredsucceeded. Callers whose ruleset still requiresci / Fastkeep that context with the real result while the gate staysci / Required. A skipped job would satisfy the ruleset, andcontinue-on-errorwould hide a failure, so neither is used.Requireddoes not needFast(that would cycle). The job uses the same lightweight runner anchor asPlanandRequired.scripts/test_taskgraph.pyexecutes the shipped step:successexits 0;failure,cancelled,skipped, empty andSUCCESSexit non-zero.lint_callables.pyrejects a skip,continue-on-error, a renamed job, a missingneeds,Requireddepending on the alias, an unbound result, and an unconditionalexit 0.Self-check:
d933fcff7e7a3d2ca51173e925d39cca1bb71b32— not a refusal, estate deploy, credential-authority, or irreversible change. The alias fails closed and does not widenpermissions.No ruleset is edited. After this merges, gonogo#362's pin of
taskgraph.yml(workflows#216,8db0a2ca78d12d9352a1b14cc76a6d7b76ab79f1) moves to this merge SHA.Local gate
python3 scripts/precheckexit 0, 713.61s wall.Refs #225