Verify the MinGW node-gyp fix in CI and guard against regressions - #7
Merged
Conversation
The pinned node-gyp devDependency (added so the MSVC jobs can detect VS2026) shadows the MSYS2-patched node-gyp under MinGW, which makes node-gyp build with MSBuild/MASM instead of `-f make` and fails on libffi's GNU-syntax win64.S. The MinGW job already drops that pin, but the push trigger ignored `.github/**`, so that fix never actually ran. - Stop ignoring `.github/**` on push and add workflow_dispatch, so workflow-only changes are validated instead of silently skipped. - Assert no local node-gyp survives `npm install` in the MinGW job, so a regression fails immediately rather than as hundreds of A2044 errors. - Document why the pin removal must precede `npm install` and why this job cannot use `npm ci`.
urbanogilson
force-pushed
the
ci/fix-mingw-node-gyp
branch
from
August 3, 2026 21:04
0091ec8 to
c0ab11a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSYS2's
mingw-w64-x86_64-nodejsships an npm whose bundled node-gyp is patched for MinGW (-f make,node_root_dir=/mingw64,node_lib_file=libnode.dll.a). A localnode_modules/node-gypshadows it —node-gyp-buildresolves viarequire.resolve('node-gyp/package.json'), andscripts.build/scripts.testpick upnode_modules/.bin/node-gypfrom PATH. Unpatched node-gyp then selects-f msvs+ MSBuild and feeds libffi's GNU-syntaxdeps/libffi/src/x86/win64.Sto MASM: hundreds oferror A2044: invalid character in file.