Skip to content

Fix Windows verification warnings and temporary directory cleanup - #61

Merged
nai62 merged 8 commits into
masterfrom
fix/windows-warnings-temp-cleanup
Nov 2, 2026
Merged

nai62 merged 8 commits into
masterfrom
fix/windows-warnings-temp-cleanup

Conversation

@nai62

@nai62 nai62 commented Nov 1, 2026 •

Copy link
Copy Markdown
Owner
  • Test fixture directories could be removed before queued QObject destruction and running page loads released their archive handles on Windows. Wait up to five seconds while processing events, and fail the test if cleanup still cannot finish.
  • Replace deprecated Qt touch and key-combination accessors and omit unused parameter names. Use zlib's CRC-32 and Qt's endian writer in a PNG chunk helper, keep generated HSV values in range, load the viewer's cursor resources in navigation tests, and leave room for the native frame around the standalone button test.
  • Update resvg to 0.49.0 and use its corrected C API error definitions. Track Cargo manifests, Cargo.lock, and Rust sources so existing libraries rebuild after a submodule update. Expand unrar header paths during qmake generation.
  • Add regressions for an open file released by an owner-thread callback, archive-load cleanup, and SVG parse, size, and gzip failures.
  • Checked scripts\verify-windows.cmd debug --qmake on Windows, including recompilation of resvg 0.49.0: exit code 0, 531 cases across all 10 suites, no failures or skips, no compiler or qmake warnings, and no new leftover fixture directories.
  • The remaining nine QWARN messages are intentional: four SVG fallback diagnostics and five broken-AVIF rejection diagnostics. Interactive Windows touch scrolling, pinch, rotation, and SVG rendering checks are still unverified.

@nai62
nai62 merged commit 0162bb2 into master Nov 2, 2026
5 checks passed
@nai62
nai62 deleted the fix/windows-warnings-temp-cleanup branch November 2, 2026 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant