Repository navigation
ci: do not run dependency install scripts in publish jobs - #10
Merged
Merged
Conversation
The publish and prerelease jobs hold publishing credentials — `id-token: write` for trusted publishing (or the PAT on the extension) — and ran a plain `npm ci`, so every devDependency's install script executed with the ability to mint a publish token. Nothing in either job needs them: they build, then publish. `npm ci --ignore-scripts` on those two steps. Test and build jobs are unchanged and still install normally. Refs galactic-config#9.
nabheet
marked this pull request as ready for review
October 31, 2026 23:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs
nabheet/galactic-config#9.Problem
The publish and prerelease jobs hold publishing credentials —
id-token: writefor trusted publishing,VSCE_PATon the extension — and run a plainnpm ci. Every dependency install script therefore executed inside a job that holds a publish token.Change
npm ci→npm ci --ignore-scriptson the two credentialed steps only. Test and build jobs are untouched and still install normally.Scope
This blocks install-time scripts only. The credential is still in the job environment for the later build/test steps — scoping it to just the publish step is a separate change, not made here.
Verification
Locally reproduced each publish job's post-
npm cisteps against a scripts-off install:The workflows lint clean with
actionlint -shellcheck=.Release impact
.github/**is non-shipping in the release guard, so the merge run reportsRESULT: changed=falseand publishes nothing.