Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #16 based on the maintainer feedback that 8 KiB chunking is required for WASM.
This keeps the existing 8 KiB AFC upload chunks on
wasm32, while using 1 MiB chunks on native targets.The goal is to reduce native AFC write round trips without changing the WASM behavior that avoids hangs.
Details
wasm32: keeps8 * 1024byte chunks1024 * 1024byte chunksisideload_vfs::fs::read()still reads the file before upload)The target architecture is used instead of the
wasmfeature flag so builds that enable the feature on a native target still use the native path.Validation
cargo check -p isideloadon Windows, macOS, and Linuxwasm32-unknown-unknowncheck with--no-default-features --features install,wasm,fs-storageIn both physical tests, the AFC transfer completed and installation proceeded to the installation proxy. The final install was then rejected because the device had already reached the free developer profile app limit, which occurs after the transfer path being tested.
Scope
This PR only changes
isideload/src/sideload/install.rsand contains no unrelated changes.