Skip to content

chore(deps): Update netdev to wine-supporting version #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
flub merged 4 commits into from
Oct 2, 2026
+50 −90
Merged

chore(deps): Update netdev to wine-supporting version #229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e7752e7
Partially revert "fix(netwatch): Support wine fully (#216)"
matheus23 Sep 11, 2026
87286b5
chore(deps): Update netdev to wine-compatible version
matheus23 Sep 11, 2026
f60c2ae
chore(netwatch): Ignore broken doc link warning
matheus23 Sep 11, 2026
2a11e7f
Merge branch 'main' into matheus23/netdev-update
flub Oct 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
123 changes: 44 additions & 79 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 2 additions & 11 deletions netwatch/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,17 +42,8 @@ socket2 = { version = "0.6", features = ["all"] }
tokio = { version = "1", features = ["rt", "net"] }

# netdev is available on all non-embedded, non-wasm platforms
# temp older version for windows: https://github.com/shellrow/netdev/pull/186
[target.'cfg(not(any(target_os = "espidf", all(target_family = "wasm", target_os = "unknown"), target_os = "windows")))'.dependencies]
netdev = "0.46.1"
tokio = { version = "1", features = [
"fs",
"io-std",
] }

# temp older version of netdev for windows: https://github.com/shellrow/netdev/pull/186
[target.'cfg(all(not(any(target_os = "espidf", all(target_family = "wasm", target_os = "unknown"))), target_os = "windows"))'.dependencies]
netdev = "0.45.0"
[target.'cfg(not(any(target_os = "espidf", all(target_family = "wasm", target_os = "unknown"))))'.dependencies]
netdev = "0.46.2"
tokio = { version = "1", features = [
"fs",
"io-std",
Expand Down
4 changes: 4 additions & 0 deletions netwatch/src/udp.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,10 @@ pub struct UdpSocket {
/// is the max supported by a default configuration of macOS. Some platforms will silently clamp the value.
const SOCKET_BUFFER_SIZE: usize = 7 << 20;

#[allow(
rustdoc::broken_intra_doc_links,
reason = "AsFd and AsSocket are only conditionally imported based on the target"

@flub flub Oct 2, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL you can set a reason to allow, nice!

)]
/// A socket that is about to be bound, handed to the hook set with
/// [`BindOptions::configure_socket`].
///
Expand Down
Loading