Repository navigation
Conversation
An area can have thousands of related objects, and this will quickly crash the server as it runs out of memory.
dracos
approved these changes
Oct 16, 2026
dracos
left a comment
Member
There was a problem hiding this comment.
This looks good, sorry for the delay in getting around to it!
Having thought about it, just to try and prevent the possibility of a mis-click causing an issue in future, we should probably also then look at not showing any related fields if someone tries to delete any of Country, a Generation, a NameType, a CodeType, or a Type? Feels like the Area list alone (ignoring the Area's "children" that this PR fixes) for one of those could be very large (e.g. 115k NameType "S" in the db, 138k "ons" CodeType).
Author
|
If we want to expand it to other models, then a |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure how I feel about doing a global patch:
but I can't think of another way other than duplicating
get_deleted_objectsin a Mixin and then using that on every class that has an area below it. And that feels just as wrong but in a different way.Closes #448.