Skip to content

fix: stop flagging current ask-user hooks as legacy #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mylee04 merged 1 commit into from
Sep 4, 2026
Merged

fix: stop flagging current ask-user hooks as legacy #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/code-notify/core/config.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,7 +448,7 @@ has_legacy_global_claude_hooks() {

grep -q 'claude-notify' "$file" ||
grep -qE 'notifier\.sh (notification|stop)"' "$file" ||
grep -q 'notifier.sh PreToolUse' "$file" ||
grep -qE 'notifier\.sh PreToolUse"' "$file" ||
grep -qE 'notify\.ps1.* (notification|stop)"' "$file" ||
grep -qE 'notify\.ps1.* PreToolUse' "$file"
}
Expand Down
29 changes: 28 additions & 1 deletion tests/test-ask-user-alert.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ mkdir -p "$CLAUDE_HOME/notifications"

source "$ROOT_DIR/lib/code-notify/core/config.sh"

notify_script="$test_dir/notify.sh"
notify_script="$test_dir/notifier.sh"
get_notify_script() {
printf '%s\n' "$notify_script"
}
Expand Down Expand Up @@ -54,6 +54,10 @@ set_notify_types "idle_prompt|ask_user"
enable_hooks_in_settings
enable_hooks_in_settings

if claude_global_hooks_need_repair; then
fail "current ask_user hook was incorrectly flagged as legacy"
fi

python3 - "$GLOBAL_SETTINGS_FILE" "$notify_script" <<'PYTHON'
import json
import sys
Expand Down Expand Up @@ -91,6 +95,29 @@ if not any(
raise SystemExit("custom non-AskUserQuestion PreToolUse hook was not preserved")
PYTHON

legacy_settings_file="$test_dir/legacy-settings.json"
cat > "$legacy_settings_file" <<JSON
{
"hooks": {
"PreToolUse": [
{
"matcher": "AskUserQuestion",
"hooks": [
{
"type": "command",
"command": "$notify_script PreToolUse"
}
]
}
]
}
}
JSON

if ! has_legacy_global_claude_hooks "$legacy_settings_file"; then
fail "legacy PreToolUse hook was not flagged for repair"
fi

unregister_ask_user_hook "$GLOBAL_SETTINGS_FILE" "$(get_global_claude_pre_tool_use_command)"

python3 - "$GLOBAL_SETTINGS_FILE" "$notify_script" <<'PYTHON'
Expand Down