Skip to content

The page chooses EM's fields and says what limits the run - #145

Merged
mvsbm merged 1 commit into
mainfrom
page-em-diagnosis
Nov 15, 2026
Merged

mvsbm merged 1 commit into
mainfrom
page-em-diagnosis

Conversation

@mvsbm

@mvsbm mvsbm commented Nov 15, 2026 •

Copy link
Copy Markdown
Owner

What and why

Two things only the CLI and report.txt had are now on the page.

  • Choose EM. The Method page has a card "Which fields should EM learn from?". Its answer line says what method.toml's fit em is: as tuned, chosen by each run, or the fields named. Its button "✦ Choose EM fields" runs nayose choose em (declared in the page's layout, busy label "Choosing EM's fields"). It then shows each session (pairs, share agreeing on the given name, kept or dropped, why), a banner with the sessions kept now and a Find matches link, and the comparisons that took every session's m. The Try sample labels understand em choose ("EM chosen by the given name"), and a list of fields reads as "EM per …". The button is not on the Your data step: choose em needs a run, and there is none yet at that step.
  • DIAGNOSIS. report.diagnosis now returns items (what, pairs, fix). report.diagnosis_lines prints report.txt's lines from them, unchanged. Run.report makes the items once, prints them and keeps them in the report step's facts in steps.json. describe workspace gives them as diagnosis, from the last run that wrote a report; it is null for an older run that has none. On Find matches, a card "What limits what the run finds?" lists them, the most pairs first. A choose em or try sample fix is a button that opens the Method page and presses its button, --records included. Any other fix shows its command line, with the real workspace, and a copy button. No items: one line, "Nothing found.". Null: no card.

Tests: describe workspace returns the items, and report.txt prints the same ones; an older steps.json gives null. A browser walkthrough covers the diagnosis card (light and dark), choose em writing fit em "choose" from a double click that sends one request, a rerun, a diagnosis fix button carrying --records, an older run with no card, a workspace with no run, and a lost server freeing the button. Full suite on 3.14 (301 passed) and the non-browser tier on 3.12 (277 passed); ruff clean.

Checklist (CONTRIBUTING.md)

  • Reviewed before merging: a review pass on this pull request's changes (rule 10)
  • Unhappy paths tested at the real size: two at once, an input twice, the real data size, a lost server (rule 9)
  • Every new limit names itself (shortcut: …), and every store that grows says what bounds it (rules 3 and 4)
  • Docs and diagrams describe the code as it is

🤖 Generated with Claude Code

… page's "Which fields should EM learn from?" runs choose em (each session kept or dropped and why, then Find matches); Find matches lists report.txt's DIAGNOSIS items, kept in steps.json and given by describe workspace as diagnosis

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012o8JNBKSY1aREPbMQDG8g2
@mvsbm
mvsbm merged commit e1358d5 into main Nov 15, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant