Skip to content

Data and text studio, typed and tested workflow code, one type standard, datasets by reference - #8

Open
mvsbm wants to merge 3 commits into
feat/workflow-tabsfrom
fix/debt-pass
Open

mvsbm wants to merge 3 commits into
feat/workflow-tabsfrom
fix/debt-pass

Conversation

@mvsbm

@mvsbm mvsbm commented Oct 21, 2026

Copy link
Copy Markdown
Owner

Stacked on #7 (merge #7 first; this PR then retargets main).

Debt pass: the nayose reference is true to its own design and its App takes uploads; new tabs start empty; the Templates browser shows only the studio's templates; ComfyUI's image/3D/audio editors are off by default (native setting); only this node pack loads on 8188; no deprecated ComfyUI APIs (credentials dialog, input links); the Contract, Data and Design tabs, chat panel and dialog in ComfyUI's native look.

Workflow code as a tier of node: a tool has a node's interface (typed ports checked on every run), its own tests (examples, run before approval and in Run checks as "tool tests"), and says why no node would do; it is traced in its stage's LLD and visible in the Design tab, Versions (code diff) and on its stage card; a graduation brief turns a proven tool into a reviewed studio node.

One type standard (STANDARDS.md, standards/): closed core types plus per-domain dataset classes, as data; every port, tool port, API kind, review rule and agent schema reads it; unregistered types are refused; old names resolve as aliases and saved workflows open with today's names.

Datasets by reference: steps hand on {kind: studio#dataset, class, name, uri, …} and read exactly the file they are given. Cluster guard and the Clusters tab are generic; the workflow names its datasets (customers).

Tests: lint, 245 unit tests, web tests, 14 platform checks, every browser test in both add-on modes; the reference rebuilt (12/12 gates, F1 0.935); real-agent evals (Pi DeepSeek, Claude Code Haiku) on orders_api and a new code_tool task.

🤖 Generated with Claude Code

https://claude.ai/code/session_01TBhEZ9Kdkj46ENKUQjk9FP

mvsbm and others added 3 commits October 21, 2026 12:11
…standard, datasets by reference

Debt pass
- The nayose reference is true to its own design: a setting promoted to a stage card is not data
  the design takes (infer_realizes). Its input is the Data folder node, with Upload in App mode.
- A new or closed tab starts empty; the Templates browser lists only the studio's templates (with
  pictures, under "Agent Workflow Studio"); ComfyUI's image, 3D and audio editors are off by default
  (studio_defaults.py, the native Comfy.Extension.Disabled); 8188 loads only this node pack.
- No deprecated ComfyUI APIs: a native <dialog> for credentials (not scripts/ui.js); input links
  read through getInputLink/isInputConnected (the base LGraphNode one for stage cards).
- Contract, Data, Design tabs, the chat panel and the credentials dialog in ComfyUI's native look;
  theme-safe accent colours. Learn weights' Starting rules behind "Show advanced inputs".

Workflow code as a tier of node
- A tool has a node's interface (typed ports, checked on every run), its own tests (examples, run in
  the sandbox before approval and as the "tool tests" level of Run checks) and says why no node
  would do. It is a node of its stage's LLD; the stage card says "workflow code"; the Design tab
  shows its interface, tests and source; Versions shows its code diff; a Graduation brief hands a
  developer what turning it into a studio node needs. The reference is renamed "Studio - Nayose
  reference" (built from the studio's own nodes only).

One type standard (STANDARDS.md, standards/)
- A registry as data: closed core types (STRING, INT, FLOAT, BOOLEAN, JSON, TABLE, DATASET, FILE,
  FOLDER) and dataset classes per domain (matching: record_pairs, pair_decisions, record_clusters;
  synthetic). A workflow names its datasets (a record_clusters dataset named customers). Every port,
  tool port, API kind, review rule and the agents' schemas read it; unregistered types are refused;
  old names resolve as aliases and saved workflows open with today's names (unless another installed
  pack still uses the old name). The model maps storage, compute, jobs and orchestration to Google
  Cloud's.

Datasets by reference
- Steps hand on {kind: studio#dataset, class, name, uri, format, row_count, subset, inputs} and read
  exactly the file they are given, not the newest of a name. The Data tab shows each entity's
  dataset; Cluster guard and the Clusters tab speak of clusters, in the workflow's own word inside.
  Stage ports are named by the design when nodes are packed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TBhEZ9Kdkj46ENKUQjk9FP
- Graduation end to end, as a browser test (tests/e2e/graduation.cjs): the brief names the stages that
  run the tool and says to rebuild them with comfy_build_step; a node written from it passes the
  tool's examples as a node, the stage is rebuilt with it, and the workflow's CI stays green with no
  code of its own.
- The agent's scope check matches the studio's pack exactly (not any pack whose name starts so).
- Versions keeps each version's row across reloads: an opened version stays open, and a reload never
  swaps the row being clicked (the CI flake in agent_tool.cjs).
- CI: one run per change (push builds main only; branches build through their pull request); lint,
  unit tests and the browser tests in three shards run in parallel (scripts/e2e.sh platform|chat|data);
  the run without Pi add-ons covers only the chat test (only the chat header differs; pi_startup
  checks both). A unit test fails a browser test that sits in no shard.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TBhEZ9Kdkj46ENKUQjk9FP
…des out index timeouts

- Each showing of a workflow tab stamps its panel; the Design tab's matrix (loaded from the server)
  writes only if its showing is still current. On a slow machine it finished after a switch to
  Versions and replaced that tab's content (the agent_tool.cjs failure in CI).
- CI: uv's download timeout and retries raised (a PyPI timeout failed an install).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TBhEZ9Kdkj46ENKUQjk9FP
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant