Simplify code around building windows. - #260
Merged
Merged
Conversation
andy128k
changed the title
Owner
|
This has a conflict now |
Contributor
Author
|
@mvo5 rebased |
mvo5
approved these changes
Aug 1, 2026
mvo5
left a comment
mvo5
left a comment
Owner
There was a problem hiding this comment.
Thanks! This looks fine, nice cleanup! Unfortunately conflicts again :/
|
|
||
| // user pressed ctrl-c | ||
| if (event->keyval == GDK_c && event->state & GDK_CONTROL_MASK) { | ||
| if (event->keyval == GDK_KEY_c && event->state & GDK_CONTROL_MASK) { |
Owner
There was a problem hiding this comment.
(super nitpick) in an ideal world this would be its own commit but its fine :)
mvo5
approved these changes
Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify code around building windows.
Make
close()method return nothing. It and its overrides returntrueanyway. That's not a big deal now but clears a bit situation when implementation needs to be asynchronous (e.g. in Gtk4).