Convert Sendspin pairing to the spec's pairing-code dialect - #6080
Draft
teancom wants to merge 1 commit into
Draft
Convert Sendspin pairing to the spec's pairing-code dialect#6080teancom wants to merge 1 commit into
teancom wants to merge 1 commit into
Conversation
Contributor
Author
|
The aiosendspin PR. |
Contributor
Merging this PR will not alter performance
Comparing Footnotes
|
Contributor
🔒 Dependency Security Report📦 Modified Dependencies
|
| Name | Skip Reason |
|---|---|
| aiolibdatachannel | Dependency not found on PyPI and could not be audited: aiolibdatachannel (2026.5.23.dev4+g950e7f0) |
| aiosendspin | Dependency not found on PyPI and could not be audited: aiosendspin (0.0.0) |
| torch | Dependency not found on PyPI and could not be audited: torch (2.13.0+cpu) |
| torchaudio | Dependency not found on PyPI and could not be audited: torchaudio (2.11.0+cpu) |
✅ No known vulnerabilities found
Automated Security Checks
- ✅ Vulnerability Scan: Passed - No known vulnerabilities
- ✅ Trusted Sources: All packages have verified source repositories
- ✅ Typosquatting Check: No suspicious package names detected
- ✅ License Compatibility: All licenses are OSI-approved and compatible
- ✅ Supply Chain Risk: Passed - packages appear mature and maintained
Manual Review
Maintainer approval required:
- I have reviewed the changes above and approve these dependency updates
To approve: Comment /approve-dependencies or manually add the dependencies-reviewed label.
teancom
marked this pull request as draft
August 28, 2026 07:33
Follow aiosendspin's feat/pairing-code-wire branch: pairing methods are now dynamic_pairing_code/static_pairing_code with format descriptors (digits/qr_code) instead of the old PIN dialect's negotiated lengths. The provider selects the digits format, rejects QR-only clients with a localized error, and presents fixed-length forms: six digits (###-###) for dynamic codes and eight (####-####) for static. All pin_* naming in the provider and tests is renamed to pairing-code terms; MA-internal config/form option keys keep their persisted values. Manifest pins aiosendspin to the feat/pairing-code-wire branch.
teancom
force-pushed
the
test/aiosendspin-pairing-code
branch
from
September 2, 2026 05:22
d186533 to
521a768
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
Pairing methods are now dynamic_pairing_code/static_pairing_code with format descriptors (digits/qr_code) instead of the old PIN dialect's negotiated lengths. The provider selects the digits format, rejects QR-only clients with a localized error, and presents fixed-length forms: six digits (###-###) for dynamic codes and eight (####-####) for static. All pin_* naming in the provider and tests is renamed to pairing-code terms; MA-internal config/form option keys keep their persisted values.
Currently points at a branch of aiosendspin, which is why I'm opening it as a DRAFT. If/when the aiosendspin PR is merged and released, I'll update this PR to use it (and rebase and cleanup the inevitable merge conflicts by then).
Types of changes
bugfixnew-featureenhancementnew-providerbreaking-changerefactordocumentationmaintenancecidependenciesChecklist
pre-commit run --all-filespasses.pytestpasses, and tests have been added/updated undertests/where applicable.music-assistant/modelsis linked.music-assistant/frontendis linked.