Skip to content

Cloud. Removed interactive from service + added mocks - #255

Open
Eism wants to merge 2 commits into
musescore:mainfrom
Eism:publish_to_cloud_crash_fix
Open

Cloud. Removed interactive from service + added mocks#255
Eism wants to merge 2 commits into
musescore:mainfrom
Eism:publish_to_cloud_crash_fix

Conversation

@Eism

@Eism Eism commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@Eism
Eism requested a review from RomanPudashkin August 28, 2026 15:02
@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 60d1cf04-606a-4852-b254-5965ab9984ac

📥 Commits

Reviewing files that changed from the base of the PR and between 4b20139 and 15bb7a2.

📒 Files selected for processing (2)
  • framework/stubs/cloud/authorizationservicestub.cpp
  • framework/stubs/cloud/authorizationservicestub.h
💤 Files with no reviewable changes (2)
  • framework/stubs/cloud/authorizationservicestub.cpp
  • framework/stubs/cloud/authorizationservicestub.h

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The cloud authorization-check API and its AbstractCloudService implementation were removed. AbstractCloudService now uses IPlatformInteractive through global injection. Obsolete includes were removed. Google Mock implementations were added for cloud authorization, audio communication, MuseScore communication, and platform interaction interfaces.

Merge Risk: ⚪ Minimal · up to 15bb7

This change is merge-ready after normal checks and review; no actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning No pull request description was provided. It omits the required issue reference, change motivation, checklist, and build configuration details. Add a description that follows the repository template. Include the resolved issue reference, a short motivation and change summary, completed checklist items, testing information, and any required build configuration.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 8 functions across 4 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the two main changes: removing interactive service dependency and adding mocks.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Eism
Eism force-pushed the publish_to_cloud_crash_fix branch from 4b20139 to 15bb7a2 Compare August 28, 2026 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant