Let the application own the MUSE_COMPILE_USE_PCH option

[luapmartin]

Removes the MUSE_COMPILE_USE_PCH declaration from MuseDeclareOptions.cmake so the application owns the option, matching how MUSE_COMPILE_USE_UNITY already works (declared app-side, consumed by DeclareModuleSetup.cmake / MuseCreateModule.cmake).

Motivation: with the framework declaring it, an application wanting visibility/control of the default has to rely on option() first-declaration-wins ordering (see review discussion in audacity/audacity#11795).

Note for consumers: an application that does not declare MUSE_COMPILE_USE_PCH now builds without PCH (undefined → falsy in the gating checks). Audacity will declare it app-side when bumping the framework.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: d78b7547-9d41-453d-83eb-d09ecee23f02

📥 Commits

Reviewing files that changed from the base of the PR and between e5ca9ea and 82dc7f3.

📒 Files selected for processing (1)

• CMakeLists.txt

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

The top-level CMakeLists.txt now declares the cached MUSE_COMPILE_USE_PCH option with a default value of ON. The framework CMake option declarations no longer define this option.

Merge Risk: ⚪ Minimal · up to 82dc7

The application now owns the PCH build option; consumers that do not declare it will build without PCH, while this repository enables it by default. No actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description clearly explains the change, motivation, behavior for consumers, and planned Audacity follow-up. However, it omits the required issue reference, checklist completion, and build configu…	Add the Resolves issue reference, complete each applicable checklist item, and include or explicitly remove the Build configuration section according to the repository template.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly states the primary change: the application owns the MUSE_COMPILE_USE_PCH option.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Description check

Explanation

The description clearly explains the change, motivation, behavior for consumers, and planned Audacity follow-up. However, it omits the required issue reference, checklist completion, and build configuration section from the repository template.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

• Fix all pre-merge checks with AI

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}