Skip to content

Linux file picker can select several files #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
saintmatthieu wants to merge 1 commit into
base: main
Choose a base branch
from
+19 −4
Draft

Linux file picker can select several files #243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions framework/interactive/internal/interactive.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,8 +432,19 @@ io::paths_t Interactive::selectOpeningFilesSync(const std::string& title, const

return paths;
#else
NOT_SUPPORTED;
return io::paths_t{ selectOpeningFileSync(title, dir, filter, options) };
UriQuery q = makeSelectFileQuery(FileDialogMode::OpenFiles, title, dir, filter, options);

RetVal<Val> rv = openSync(q);
if (!rv.ret) {
return io::paths_t();
}

io::paths_t paths;
for (const Val& val : rv.val.toList()) {
paths.push_back(QUrl::fromUserInput(val.toQString()).toLocalFile());
}

return paths;
#endif
}

Expand Down
8 changes: 6 additions & 2 deletions framework/interactive/qml/Muse/Interactive/FileDialog.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,12 @@ QtPlatform.FileDialog {

onAccepted: {
if (root.fileMode === FileDialog.OpenFiles) {
const selectedUrls = root.fileUrls || []
root.ret = { "errcode": 0, "value": selectedUrls }
let selectedFiles = []
const selectedUrls = root.files || []
for (let i = 0; i < selectedUrls.length; ++i) {
selectedFiles.push(selectedUrls[i].toString())
}
root.ret = { "errcode": 0, "value": selectedFiles }
} else if (root.fileMode === FileDialog.SaveFile) {
root.ret = { "errcode": 0, "value": root.appendSuffixIfNeeded(root.currentFile.toString()) }
} else {
Expand Down