Open links in standard dialog texts - #233
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughStyledTextLabel now sets Merge Risk: ⚪ Minimal · up to This is a narrowly scoped change to how links are opened in standard dialog text, with no actionable merge-blocking risk remaining beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
220f4b0 to
5e61f6f
Compare
|
Would this be fixing the issue mentioned in musescore/MuseScore#33712 (comment) ? |
|
@Jojo-Schmitz it should, yes |
|
Wonderful, looking forward to it getting merged |
Open links in standard dialog texts
Resolves: #11725 Merge only with bumped framework containing musescore/muse_framework#233 change - [x] I signed [CLA](https://www.audacityteam.org/cla/) - [x] The title of the pull request describes an issue it addresses - [x] If changes are extensive, then there is a sequence of easily reviewable commits - [x] Each commit's message describes its purpose and effects - [x] There are no behavior changes unnecessary for the stated purpose of the PR Recommended: - [x] Each commit compiles and runs on my machine without known undesirable changes of behavior QA: - [ ] Testflow test cases have been run - [ ] Test if all the URLs in the AU4 open a browser correctly
Resolves: #11725 Merge only with bumped framework containing musescore/muse_framework#233 change - [x] I signed [CLA](https://www.audacityteam.org/cla/) - [x] The title of the pull request describes an issue it addresses - [x] If changes are extensive, then there is a sequence of easily reviewable commits - [x] Each commit's message describes its purpose and effects - [x] There are no behavior changes unnecessary for the stated purpose of the PR Recommended: - [x] Each commit compiles and runs on my machine without known undesirable changes of behavior QA: - [ ] Testflow test cases have been run - [ ] Test if all the URLs in the AU4 open a browser correctly
Resolves: audacity/audacity#11725