MIDI export: apply accent- and marcato-based compound articulations - #34706
Open
hashimh4 wants to merge 1 commit into
Open
MIDI export: apply accent- and marcato-based compound articulations#34706hashimh4 wants to merge 1 commit into
hashimh4 wants to merge 1 commit into
Conversation
Accent-staccato was exported with no shortening and no velocity change, even though MuseScore plays it correctly. symId2ArticulationName() calls these symbols sforzatoStaccato, sforzatoTenuto, marcatoStaccato and marcatoTenuto, and none of those names were in s_builtInArticulationsValues. fillArticulationsInfo() only walks that map, so updateGateTime() and velocityMultiplierByInstrument() fell back to the instrument articulation list, which a score made in MuseScore 4 does not have. The values come from ARTICULATION_ABOVE_SPLIT_GROUPS: velocity of the accent or marcato, gate time of the staccato or tenuto. Scores that do carry an instrument articulation list are unaffected. Resolves: musescore#31432
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #31432
Accent-staccato, accent-tenuto, marcato-staccato and marcato-tenuto were missing from
s_builtInArticulationsValues, so MIDI export applied neither their shortening nor their velocity change, although MuseScore plays them correctly. The values follow the decomposition inARTICULATION_ABOVE_SPLIT_GROUPS. Scores that store an instrument articulation list resolve through it as before and are unaffected.Built in CI; I tested the resulting Windows build against the score attached to the issue, and its export before the fix is byte-identical to the reporter's own.