Skip to content

Preparations for release#48

Merged
muesli4 merged 7 commits into
masterfrom
add-table-spec
Nov 3, 2022
Merged

Preparations for release#48
muesli4 merged 7 commits into
masterfrom
add-table-spec

Conversation

@muesli4

@muesli4 muesli4 commented Nov 1, 2022

Copy link
Copy Markdown
Owner

I am currently in the process of cleaning up. Since we are breaking compatibility anyway, I use this as an opportunity to restructure some of the code.

@Xitian9

Xitian9 commented Nov 1, 2022

Copy link
Copy Markdown
Collaborator

I'll review this later today.

I also have an update to #34 coming, but since it conflicts with some of the changes in #45, I'll wait until this is merged to push.

@muesli4

muesli4 commented Nov 1, 2022

Copy link
Copy Markdown
Owner Author

@Xitian9, I don't mind rebasing.

@muesli4
muesli4 marked this pull request as ready for review November 1, 2022 22:26
@muesli4

muesli4 commented Nov 1, 2022

Copy link
Copy Markdown
Owner Author

If it is too much for you, you don't have to go into detail. But you are obviously welcome to do so. And please be pedantic and let me know if you do not like a specific change.

The first 3 commits are from #46.

documentation

@muesli4
muesli4 force-pushed the add-table-spec branch 2 times, most recently from 5c260fd to a3628fb Compare November 1, 2022 23:17
Comment thread src/Text/Layout/Table/Primitives/ColumnModifier.hs Outdated
Comment thread src/Text/Layout/Table/Spec/RowGroup.hs Outdated
Comment thread src/Text/Layout/Table/Spec/RowGroup.hs Outdated
Comment thread src/Test.hs Outdated
Comment thread src/Text/Layout/Table/Spec/TableSpec.hs Outdated
Comment thread src/Text/Layout/Table.hs
@muesli4
muesli4 force-pushed the add-table-spec branch 2 times, most recently from 639552c to 2ea093e Compare November 2, 2022 23:20
@muesli4 muesli4 mentioned this pull request Nov 2, 2022
Comment thread src/Text/Layout/Table/Primitives/ColumnModifier.hs
Refactor arguments of table functions into a separate type and provide
smart constructors which ease creation.
* Restructure main module.
* Capitalize titles.
* Update outdated documentation.
* Add missing documentation.
* Clean up and simplify existing documentation.
* Rename functions to clearly state purpose.
* Update documentation.
* Refactor some uses.
@muesli4
muesli4 merged commit 751b7c9 into master Nov 3, 2022
@muesli4
muesli4 deleted the add-table-spec branch November 3, 2022 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants