Conversation
…ed, and reconcile the tree to its gate Merge 4099082 resolved scripts/check-agent-record.py to its pre-restructure parent, silently discarding the restructured checker that the merge's second parent carried: fence-aware link extraction, strip_code_spans, the record-anchor ratchet, the mudler#3099 claim-state consistency gate, the roadmap issue-row refusal, and derived matrix counts. The tests re-pointed at the restructured surface (1de097c) then failed against a checker that no longer exposed it: 124 tests, 93 failures and 31 errors at the stale local main, still 72F/83P at origin/main. RESTORED: scripts/check-agent-record.py now carries the restructured implementation again (merge parent 8b5435b), whose counts are DERIVED from the rows rather than pinned. The model-inventory constants are regenerated to the current tree (rows 324, memberships 373, architectures 356, targets 309, modules 245) with an annotation naming the SystemOne decision-row closure that explains the delta, and the citation-preserving padding is kept intact so the tracked line anchors still resolve. RECONCILED, each because the lax interim checker had accepted it: seven claim files now annotate their row's matrix lifecycle state; roadmap_v1 no longer stores fifty GitHub issue table rows and points at .agentss/issues/ authority instead; three issue files move to row-named directories whose Row field names a canonical claimable row (MODEL-DSV4-EXL3, the DeepSeek-V4 text row, MODEL-GLINER25); the new _owed issue is listed under the owning spec's ## Owed; and 44 stale or broken record anchors are re-pointed to the lines that now hold what the prose says — including the four server-CLI anchors, whose file shrank to a thin ABI client and whose flags now parse in src/vllm/entrypoints/openai/server_main.cpp. TESTS: the mutation tests that pinned the retired per-matrix count constants are deleted with a comment naming the retired capability — the restored checker derives counts, so there is no constant to ratchet. The check_issue_records test shim is dropped (the restructured checker owns the real entry point), the derived-count membership tests are re-composed against the path-only MATRICES registry, and test_record_merge_shape reads the ClaimRecord shape the claim-state gate needs. GATES: python3 scripts/check-agent-record.py OK (ENGINE=179 MODEL=384 QUANT=87 KERNEL=60 BACKEND=90 ANCHOR-ROT=0); pytest tests/scripts/test_agent_record.py 123 passed, 60 subtests passed; test_record_merge_shape and test_issue_records green. Fixes ISSUE-LOCAL-01M3JMSD9P7REKNQVEG9HCEWTD FOLLOWING_AGENTS_PROTOCOL Following-Agents-Protocol: true AI-Assisted: true Assisted-by: AGENT:zai/glm-5.3-flash [maki]
…oncile the drifted records The 4099082 merge dropped the restructured check-agent-record checker, so main carried the old count-constant monolith against a test suite written for the restructured API: tests/scripts/test_agent_record.py failed with 29 errors and 6 failures on a tree the old checker called green. Restore the restructured checker (cherry-pick of bdcf37fa9's scripts/check-agent-record.py and scripts/issue_records.py, whose counts are derived from the rows, so the stale ENGINE/MODEL/QUANT/BACKEND count constants and the model-inventory dict drift disappear as a class), then reconcile the tree the restored gate actually flagged: - Claims/specs: muse-glimmer-parity.md and nano-nemotron-vl-radio.md listed three row-owned issue IDs (01M3S0ZTRRVQWCZ35W33AJJNN8, 01M3RY6G385D41W5SNF1C85RRS, 01M3S07X6Y4ADHHQ02FYMR4RXF) under ## Owed; a spec's Owed section may only own _owed IDs, so each reference moved to a new ## Tracked section with the same traceability. The MiMoV2 issue carried the invalid State PARTIAL; the row is ACTIVE (W1 landed, CLAIM-MIMOV2-PORT), so the issue is OPEN. - Record anchors: 10 citations in engine-matrix.md named lines the prose no longer holds (handle_metrics 1322->1354, handle_tokenize 1333->1365, set_tokenizer_info_enabled 396->408, kAcceptedInertArgs 339->409, handle_abort_requests 1582->1614, set_abort_requests 403->415, LoadedEngine::FromModelDir 2548->2556, process_inputs 249->266, plus the two duplicate row-cell spellings); anchor rot returns to 0 against the unchanged baseline. - Checker-line citations: six tracked specs cite check-agent-record.py line numbers the restore moved; re-pointed each to the line that now holds the cited statement (link_bases region 1078-1107->1094-1184, check_spec 1169->1857, the active-claim Row-ID refusal 1712-1714 -> 1975 with the ID_RE prefix list 327-338->903-906, ISSUE_ROW 1960->2052, owed_issues 2000->2017, check_issue_index 2018->2044). - Tests: test_malformed_row_is_still_seen_downstream asserted the retired count-constant error format; the restructured checker already reports both the shape and the duplicate finding in one run, so the obsolete third require is re-pointed at that contract instead. The checker-line citation scan now skips a tracked symlink dereferenced to a directory (.agents/evidence/.../latest), which carries no line citation. test_agent_record.py: 106/106. Files: ISSUE-LOCAL-01M3SQTG14MVDB5MWCQPB418QM FOLLOWING_AGENTS_PROTOCOL Following-Agents-Protocol: true AI-Assisted: true Assisted-by: AGENT:zai/glm-5.3-flash [maki]
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The record-checker CI gate is red because merge 4099082 resolved to the pre-restructure checker and dropped the reviewed restructured one; the restore existed unmerged on row/ci-rot-repairs. This branch lands that restore (derived counts replace the stale constant monolith: ENGINE=179 MODEL=384 QUANT=87 KERNEL=60 BACKEND=90, anchor rot 0) and reconciles the tree to it: three row-owned issue IDs moved from Owed to new Tracked sections (Owed only owns _owed IDs), the MiMoV2 issue state re-pointed to its ACTIVE row, ten stale record anchors and six stale checker-line citations re-pinned with git-log evidence, and the checker's test suite updated to the restored contract — 106/106 OK, from 29 errors + 6 failures. Re-pointed, not deleted, throughout; each re-point cites its diff evidence in the body. Issue: ISSUE-LOCAL-01M3SQTG14MVDB5MWCQPB418QM.
FOLLOWING_AGENTS_PROTOCOL
Following-Agents-Protocol: true
AI-Assisted: true
Assisted-by: AGENT:zai/glm-5.3-flash [maki]