Skip to content

[Windows] full build fails in tools/bench/conv1d_scaling_probe.cpp (POSIX-only sys/resource.h) #3309

Description

@ElderOrb

Summary

A full (all-target) configure + build on Windows stops on a bench probe that includes a
POSIX-only header:

FAILED: [code=1] CMakeFiles/vllm_conv1d_scaling_probe.dir/tools/bench/conv1d_scaling_probe.cpp.obj
C:\TheRock\10.0.0-official\build\lib\llvm\bin\clang++.exe ... -c tools/bench/conv1d_scaling_probe.cpp
tools/bench/conv1d_scaling_probe.cpp:57:10: fatal error: 'sys/resource.h' file not found
   57 | #include <sys/resource.h>
      |          ^~~~~~~~~~~~~~~~
1 error generated.
ninja: build stopped: subcommand failed.

cmake --build . --target server is unaffected (that is what we build), but a plain
cmake --build . cannot complete on Windows, and the probe target cannot be built for
ctest runs there.

Environment

  • Windows 11 (26200), native Windows build with clang/lld from TheRock 10.0, HIP gfx1151
  • commit 6369267, Ninja generator, --parallel 16

Suggested change

Guard the POSIX-only include/usage with #if !defined(_WIN32) (as other tools in the tree
already do), or exclude this probe from the default target set on Windows.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions