Summary
A full (all-target) configure + build on Windows stops on a bench probe that includes a
POSIX-only header:
FAILED: [code=1] CMakeFiles/vllm_conv1d_scaling_probe.dir/tools/bench/conv1d_scaling_probe.cpp.obj
C:\TheRock\10.0.0-official\build\lib\llvm\bin\clang++.exe ... -c tools/bench/conv1d_scaling_probe.cpp
tools/bench/conv1d_scaling_probe.cpp:57:10: fatal error: 'sys/resource.h' file not found
57 | #include <sys/resource.h>
| ^~~~~~~~~~~~~~~~
1 error generated.
ninja: build stopped: subcommand failed.
cmake --build . --target server is unaffected (that is what we build), but a plain
cmake --build . cannot complete on Windows, and the probe target cannot be built for
ctest runs there.
Environment
- Windows 11 (26200), native Windows build with clang/lld from TheRock 10.0, HIP
gfx1151
- commit
6369267, Ninja generator, --parallel 16
Suggested change
Guard the POSIX-only include/usage with #if !defined(_WIN32) (as other tools in the tree
already do), or exclude this probe from the default target set on Windows.
Summary
A full (all-target) configure + build on Windows stops on a bench probe that includes a
POSIX-only header:
cmake --build . --target serveris unaffected (that is what we build), but a plaincmake --build .cannot complete on Windows, and the probe target cannot be built forctestruns there.Environment
gfx11516369267, Ninja generator,--parallel 16Suggested change
Guard the POSIX-only include/usage with
#if !defined(_WIN32)(as other tools in the treealready do), or exclude this probe from the default target set on Windows.