fluid system overhaul#152
Open
The4codeblocks wants to merge 60 commits into
Open
Conversation
| -- or for rendering the pipes purely decorative. | ||
| ]] | ||
| pipeworks.toggles.pipe_mode = "classic" | ||
| pipeworks.toggles.pipe_mode = "pressure" |
Member
There was a problem hiding this comment.
how does that affect existing worlds?
Contributor
Author
There was a problem hiding this comment.
a lot of the things I'm doing (whether they're currently in this PR or not) are going to break things, but the old way things work is likely simple enough to auto-reinstate the original function
Member
|
Current luacheck warnings: (i removed the ones about missing sounds good imo, didn't test that yet though |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
wsor4035
reviewed
Dec 30, 2025
Comment on lines
+323
to
+333
| if core.get_modpath("bucket") then | ||
| buckets.air = "bucket:bucket_empty" | ||
| buckets.water = "bucket:bucket_water" | ||
| buckets.river_water = "bucket:bucket_river_water" | ||
| buckets.lava = "bucket:bucket_lava" | ||
| elseif core.get_modpath("mcl_buckets") then | ||
| buckets.air = "mcl_buckets:bucket_empty" | ||
| buckets.water = "mcl_buckets:bucket_water" | ||
| buckets.river_water = "mcl_buckets:bucket_river_water" | ||
| buckets.lava = "mcl_buckets:bucket_lava" | ||
| end |
Contributor
There was a problem hiding this comment.
this should come from xcompat
Contributor
Author
There was a problem hiding this comment.
should be done
(riverwater & lava buckets don't have xcompat entries)
Contributor
|
i have only skimmed this code, but would it be possible to break parts of this pr off and merge them in? as this is quite huge |
SwissalpS
reviewed
Dec 30, 2025
oddly enough, xcompat doesn't do anything with riverwater and lava
"Deprecate flowing_logic.lua for classic flow logic Mark the file as deprecated due to new flow logic requirements." - copilot
SwissalpS
reviewed
Dec 30, 2025
This comment was marked as spam.
This comment was marked as spam.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
autocrafter fluid support
creative fluid source
trashcan acting as fluid void
flow sensor acting as a pressure gauge (shows fluid type too)
multiple fluid types (no mixing, but there is displacement)
| has custom fluid registration
| updating existing pump and drains to support multiple fluids
| per fluid "finite" config
(important detail: flow logic default set to
"pressure"instead of"classic")