Adopt shared save-state and rewind menus for Mega Man X - #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mega Man X now uses the shared snesrecomp desktop host for its F7 save-state browser, F8 rewind filmstrip, launcher hotkey/controller bindings, audio and input loop. The versioned game state adds complete execution state, first-frame flags, and widescreen spawn/CHR bookkeeping so a fresh-process load and rewind resume the same timeline.
USA and Japanese targets remain available. Game-owned widescreen/MSU-1 behavior and display-aspect/shader controls are retained; existing mod selections migrate to the shared catalog layout. CMake now uses shared host, generated-code, catalog and config helpers. The duplicate Visual Studio source lists, OpenGL presenter and loader copies are retired. CI compiles both ROM-free setup hosts.
Validation: real USA ROM full-state restore and deterministic replay, fresh-process save loading, rewind selection, F7/F8 migration/rebinding/clearing, visible controller-driven menu open/close with audio and widescreen; USA/JP Windows SDL3 builds; USA/JP ROM-free Linux SDL2 builds; display geometry and widescreen policy checks. No unrelated test or gameplay changes.
Framework dependency: RetroPortingToolKit/snesrecomp#78. Beads: beads-8wg.1.19.