ci: pin coverage Python/gcovr and align lockfile docs - #25704
Open
enochgroot wants to merge 1 commit into
Open
enochgroot wants to merge 1 commit into
enochgroot wants to merge 1 commit into
Conversation
- Pin coverage job to Python 3.12 and gcovr==8.6 - Record package 3.4.0 in package-lock.json - Name package-lock.json instead of a missing shrinkwrap in SECURITY.md
Collaborator
Author
Review (ranked)merge: nit-only on Catalog leaves on this three-file nit:
Independent coverage job Report: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up nits from the 3.4.0 re-review (
c0f78a1..4f93644). Does not change package version, engines, CI matrix, native code, or the 95% coverage gate.Changes
gcovr==8.6(drop floating3.x/ unpinned--upgrade).3.4.0inpackage-lock.jsontop-level andpackages[""].versionto matchpackage.json.package.json+package-lock.jsonin SECURITY.md inventory (there is no shrinkwrap in tree).Action
uses:SHA pins, Node 22-only matrix, andnpm cithennpm run coverageare unchanged.Please squash-merge; do not npm publish from this PR.