Skip to content

fix: null guard onBannerAdLoaded #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
felipefuzaro-funda wants to merge 1 commit into
base: ad-loader-ad
Choose a base branch
from
Open

fix: null guard onBannerAdLoaded #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .../android/src/adsNextGenSdk/java/io/flutter/plugins/googlemobileads/FlutterAdLoaderAd.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package io.flutter.plugins.googlemobileads;

import android.app.Activity;
import android.util.Log;
import android.view.View;
import androidx.annotation.NonNull;
Expand Down Expand Up @@ -271,8 +272,13 @@ public void onAdFailedToLoad(@NonNull LoadAdError loadAdError) {

@Override
public void onBannerAdLoaded(@NonNull BannerAd bannerAd) {
AdView adView = new AdView(manager.getActivity());
adView.registerBannerAd(bannerAd, manager.getActivity());
Activity activity = manager.getActivity();
if (activity == null) {
Log.e(TAG, "Tried to load banner ad before plugin is attached to an activity.");
return;
}
AdView adView = new AdView(activity);
adView.registerBannerAd(bannerAd, activity);

view = adView;
type = AdLoaderAdType.BANNER;
Expand Down
Loading