Repository navigation
fix: AdLoaderAd dropping custom targeting on next-gen Android SDK - #4
Conversation
AdLoaderAd dropping custom targeting on next-gen Android AdLoaderAd dropping custom targeting on next-gen Android SDK
|
Hey @felipefuzaro-funda. It looks like the |
eb1a9f7 to
cd93997
Compare
Good point @msbit. I've rolled it back and cherry-picked the fix. I see that some workflows failed due to formatting and the contribution guide says to run |
|
Looks good @felipefuzaro-funda. Could you squash d766609 into cba3f82 (it's basically a fixup)?
At some point that command was removed from the github workflows, so the code overall has drifted quite a bit from what the contributing guide would have you believe. It's not our problem, basically. If you wanted, you could consider running that format command then incorporating the formatting fixes related to your code, but that can be painful for files that you've just changed a few things in. |
cd93997 to
e8f2cb8
Compare
done. For me it's okay to proceed without the formatting |
|
Okay @felipefuzaro-funda, I've merged that in. I've also made another tag |
thanks @msbit! |
Problem
On the next-gen Android SDK (
USE_NEXT_GEN_SDK=true,ads-mobile-sdk:1.1.1),AdLoaderAdrequests were built without applying the ad request, so customtargeting, keywords, content URL, neighboring URLs, request agent, and PPID were
dropped. Targeted line items didn't match → No fill. Legacy play-services
and iOS were unaffected.
Fix
FlutterAdRequest(next-gen): addconfigureNativeAdRequestBuilder(...)toapply common request fields to
NativeAdRequest.Builder.FlutterAdManagerAdRequest(next-gen): override to also apply customtargeting, targeting lists, and PPID.
FlutterAdLoader(next-gen): thread the request intoloadAdLoaderAd/loadAdManagerAdLoaderAdand apply it before load.FlutterAdLoaderAd(next-gen): pass the request through inload().Notes
asGAMRequest:; no change needed.