Skip to content

feat(omarchy): support exact coordinates - #7

Merged
mryll merged 2 commits into
mryll:masterfrom
czarandy:fix/omarchy-exact-coordinates
Sep 16, 2026
Merged

mryll merged 2 commits into
mryll:masterfrom
czarandy:fix/omarchy-exact-coordinates

Conversation

@czarandy

Copy link
Copy Markdown
Contributor

Summary

  • expose lat, lon, and cityName settings in the Omarchy plugin manifest
  • forward exact coordinates to the existing meteobar CLI flags, with location remaining the fallback
  • document the settings and add adapter contract coverage

Validation

  • cargo test (87 core tests and 3 adapter tests passed)
  • cargo fmt --check
  • cargo clippy (passes with two pre-existing too-many-arguments warnings)
  • omarchy plugin validate

czarandy and others added 2 commits September 15, 2026 15:35
A display name that starts with a dash was read as an option and rejected
by clap; `--city-name=<value>` closes that. The QML test now pins the
`--lat`/`--lon` pairs in order, the joined form and the fetch key. The
settings describe the decimal point, that one empty coordinate discards
both, and that non-numeric values surface as an error in the panel.
mryll added a commit that referenced this pull request Sep 16, 2026
…ates

`lat`/`lon` (#7) win over `location` in buildCmd, so a place picked in the
editor (#6) changed nothing while a pair was stored. The edit is the newer
intent: the pair and its `cityName` go with the write, and the
unchanged-text shortcut does not skip the write while coordinates exist.
@mryll
mryll merged commit 2495538 into mryll:master Sep 16, 2026
@mryll

mryll commented Sep 16, 2026

Copy link
Copy Markdown
Owner

Merged, thanks! Released in 0.5.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants