Skip to content

feat: support for opt-in caching - #268

Merged
mrmckeb merged 2 commits into
mrmckeb:mainfrom
simon-paris:support-caching
Oct 24, 2026
Merged

mrmckeb merged 2 commits into
mrmckeb:mainfrom
simon-paris:support-caching

Conversation

@simon-paris

Copy link
Copy Markdown
Contributor

This adds caching, which is off by default and enabled using {caching: "always"}. It works by mapping from snapshots provided by typescript to snapshots generated by the plugin using a WeakMap.

The caching option allows "always" | "never". I chose to use a union instead of a bool to 1) later support for a third "only when safe" or "only when supported" option, and 2) to help indicate that it might be too aggressive since "always" sounds stronger than true.

Fixes #215

cc @jsliang

@simon-paris

Copy link
Copy Markdown
Contributor Author

Hi @mrmckeb, would you be able to review this?

@mrmckeb mrmckeb added this to the v6.0.0 milestone Oct 10, 2024
@mrmckeb

mrmckeb commented Oct 10, 2024

Copy link
Copy Markdown
Owner

Hi @simon-paris, sorry for the long delay. I changed jobs and moved cities over the last few months and didn't get much free time for open source.

I'll take a look at this with some other changes this weekend hopefully! :)

@AbhiPanseriya

Copy link
Copy Markdown

hi @mrmckeb can you help review this one?

@vaakian

vaakian commented Sep 28, 2026

Copy link
Copy Markdown

dead repo, i guess

@mrmckeb

mrmckeb commented Oct 5, 2026

Copy link
Copy Markdown
Owner

Sorry, a lot has happened since this PR was raised and I haven't made many updates to this repo in a while.

I've also been waiting to understand the plan for plugins with TypeScript 7, as that's currently incompatible with all TypeScript plugins - #301.

However, I recognise there are some big QOL updates that I can make, so I'll block some time out to take a look at those.

Keep in mind that I'm a sole maintainer, and that I work on this in my personal time.

@mrmckeb mrmckeb changed the title feat: Support for opt-in caching feat: support for opt-in caching Oct 24, 2026
@mrmckeb
mrmckeb merged commit 4000d65 into mrmckeb:main Oct 24, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VSCode Intellisense with version 5 is very slow

4 participants