Expose remote cache read errors and fail on server disconnects - #2779
Expose remote cache read errors and fail on server disconnects#2779seungpyoson wants to merge 8 commits into
Conversation
e14c22c to
5abf492
Compare
5abf492 to
83b66fd
Compare
83b66fd to
a35fe90
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2779 +/- ##
==========================================
+ Coverage 70.91% 73.21% +2.30%
==========================================
Files 72 72
Lines 37684 37695 +11
==========================================
+ Hits 26723 27600 +877
+ Misses 10961 10095 -866 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Merging this PR will not alter performance
Comparing Footnotes
|
|
Synced this PR with current main at 918b8ef. New CI, integration-test, and benchmark workflows are waiting for maintainer approval. Could a maintainer please approve the workflows and re-review the PR after they complete? The sync includes main's libc pin for the prior dist-test failure and allows CodSpeed to compare against the current runner generation. |
|
@sylvestre Could you take a look at sccache PR #2779 (#2779) when you have a chance? I synced it with current main today. The underlying bugs are still present, the patch merges cleanly, and the fork workflow runs are waiting for maintainer approval. If the approach looks good, could you approve the workflows and merge it? |
|
Quick update: the sole non-successful check on d048ff9 was the CUDA 11.8 job, which was canceled after Ubuntu package mirror requests stalled during NVCC installation; it never reached tests. I pushed empty commit acfbdca to retrigger the workflows without source changes. The new CI, integration-test, and benchmark runs are waiting for maintainer approval. |
Summary
NotFoundremote read failures through the existing cache-error statistics path instead of counting them as ordinary missesCompileStartedresponse I/O failures follow the documented default-fatal policy while preservingSCCACHE_IGNORE_SERVER_IO_ERROR=1Deliberately unchanged
Scope
One commit changes
src/cache/cache.rsandsrc/commands.rsonly. There are no documentation, protocol, cache-format, dependency, disk-cache, multi-level-cache, or client-side-storage changes. Existing documentation already describes the server-I/O policy.Validation
Focused regression tests cover unexpected direct remote read errors, default-fatal post-start disconnects, and the existing opt-in local fallback. Upstream CI and maintainer review remain required before merge.