chore: src/hpke.rs is unused - #70
Conversation
Kill it. Or otherwise, why keep it?
There was a problem hiding this comment.
Pull request overview
Removes the unused src/hpke.rs module from the repository, eliminating dead HPKE wrapper code that is not part of the crate’s module tree.
Changes:
- Deleted
src/hpke.rs(HPKE context/types/helpers and its associated unit tests).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Clean removal of dead code. src/hpke.rs was never declared as a module in lib.rs, so it was never compiled into the crate. The HPKE-related NSS binding types used by ech.rs, ssl.rs, and p11.rs come from the generated FFI bindings in bindings/bindings.toml, not from this file — those remain intact and unaffected.
Notably, the deleted test module itself contained use crate::{hpke::Aead, init} referencing a non-existent Aead type in the hpke module, which would have been a compile error if the module were ever included — further confirming this has been dead code for some time.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #70 +/- ##
==========================================
+ Coverage 70.46% 70.51% +0.05%
==========================================
Files 27 28 +1
Lines 3399 3405 +6
Branches 3399 3405 +6
==========================================
+ Hits 2395 2401 +6
+ Misses 800 799 -1
- Partials 204 205 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
martinthomson
left a comment
martinthomson
left a comment
There was a problem hiding this comment.
I think that the goal was to port the ohttp crate over to this. It seems like we can probably do that at some point and save a lot of effort over there. (The code looks a little like mine, so I think it's approximately right.)
|
OK. I'd be happier if this code lived in a PR until then (compared to being dead in the repo). |
Kill it. Or otherwise, why keep it?