docs: record create's default page width as an L9 exception - #199
Merged
Merged
Conversation
Closes #184. create gives a new page page_width max when nothing declares one, and update leaves an undeclared width alone. That difference is on purpose: a new page has no width a person set, and markfluence should create good-looking pages, while update may be touching a page someone set up by hand. It goes in L9's Accepts rather than changing either verb.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #184.
creategives a new pagepage_width: maxwhen nothing declares a width, andupdateleaves an undeclared width alone. Both are on purpose, so no behaviour changes. A page that markfluence creates should look good.updatemay be publishing to a page that markfluence didn't create, so it respects the width that page already has. This PR records the difference in the Accepts section of L9 (declared-metadata-is-asserted).