Conversation
Because: - A dropped socket is the channel server's normal answer for a channel it will not serve, but open() reported every connect failure to Sentry. - The supplicant hits it on its post-pairing reload, where the integration already ignores it, and on any webview network change. - Triage already tracks "WebSocket unexpectedly closed" as known client-side noise. This commit: - Classifies a closed socket during connect and dispatches CONNECTION_CLOSED rather than capturing an exception. - Leaves every other connect failure reporting to Sentry. - Logs the suppressed close as a console breadcrumb. - Covers both branches in pairing-channel.test.ts. Closes #FXA-14444
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
PairingChannelClient.open()reported every connect failure to Sentry, but a dropped socket is the channel server's normal answer for a channel it will not serve.This pull request
CONNECTION_CLOSED(errno 1006) rather than capturing an exception.Issue that this pull request solves
Closes: FXA-14444
Checklist
Put an
xin the boxes that applyHow to review (Optional)
Screenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
create()on the authority side still reports closed sockets; this ticket is scoped toopen().