Skip to content

feat(settings): add the passwordless Sync opt-in page - #21154

Draft
vpomerleau wants to merge 1 commit into
mainfrom
FXA-14424
Draft

feat(settings): add the passwordless Sync opt-in page#21154
vpomerleau wants to merge 1 commit into
mainfrom
FXA-14424

Conversation

@vpomerleau

Copy link
Copy Markdown
Contributor

Because

  • The offer to skip the password on later Sync sign-ins has to be made at the one
    point where it costs no extra device prompt: right after a Sync sign-in that used
    a passkey and then a password.

This pull request

  • Adds the PasswordlessSyncOptIn page alongside the other post-sign-in interstitials.
  • Renders the success banner, offer copy, enable button and decline link.
  • Swaps the enable button to a loading label while the wrap is stored, and disables
    the decline link.
  • Takes an optional localized error banner for a failed store.
  • Adds Storybook stories for the default, loading and error states, plus unit tests.

Issue that this pull request solves

Closes: FXA-14424

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).
  • I have manually reviewed all AI generated code.

How to review (Optional)

  • Key files/areas to focus on:
  • Suggested review order:
  • Risky or complex parts:

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

Any other information that is important to this pull request.

Because:
- A Sync sign-in that used a passkey and then a password is the one point
  where the offer to skip the password next time can be made without a
  second device prompt, so the flow needs a page to make it on.

This commit:
- Adds the PasswordlessSyncOptIn page alongside the other post-sign-in
  interstitials.
- Renders the success banner, offer copy, enable button and decline link.
- Swaps the enable button to a loading label while the wrap is stored, and
  disables the decline link so it cannot race the write.
- Takes an optional localized error banner for a failed store.
- Adds Storybook stories and unit tests.

Closes #FXA-14424
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant