feat(settings): add the passwordless Sync opt-in page - #21154
Draft
vpomerleau wants to merge 1 commit into
Draft
Conversation
Because: - A Sync sign-in that used a passkey and then a password is the one point where the offer to skip the password next time can be made without a second device prompt, so the flow needs a page to make it on. This commit: - Adds the PasswordlessSyncOptIn page alongside the other post-sign-in interstitials. - Renders the success banner, offer copy, enable button and decline link. - Swaps the enable button to a loading label while the wrap is stored, and disables the decline link so it cannot race the write. - Takes an optional localized error banner for a failed store. - Adds Storybook stories and unit tests. Closes #FXA-14424
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
point where it costs no extra device prompt: right after a Sync sign-in that used
a passkey and then a password.
This pull request
PasswordlessSyncOptInpage alongside the other post-sign-in interstitials.the decline link.
Issue that this pull request solves
Closes: FXA-14424
Checklist
Put an
xin the boxes that applyHow to review (Optional)
Screenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Any other information that is important to this pull request.