feat: disconnect idle existing Firefox sessions - #179
Conversation
|
Sorry about the delay for the review here, I need some more focused time to test this than for the usual PRs, but I will take a look today. |
|
No worries, take your time. |
|
Just a small note for manual testing: the idle timeout can be temporarily changed to 10 seconds locally from |
juliandescottes
left a comment
There was a problem hiding this comment.
Thanks, I would like to see a simpler implementation. The idle-connection wrapper is a bit too complex for something which only matters in one specific scenario.
I suggest to drop this wrapper and instead create a timer/promise/counter inline in CallToolRequestSchema. Downside is that we can't easily cover that with tests, but I think the simplification makes it worth this.
|
Alright, I'll rewrite and make it a simpler. |
8a5c721 to
398bab7
Compare
398bab7 to
417cc13
Compare
|
I have made the requested changes! |
Bugzilla: Bug 2066912
This change disconnects from an existing Firefox instance after 30 minutes of inactivity when using
--connect-existing. The Firefox process itself stays open, and the MCP reconnects to the same instance on the next tool call. The idle timeout is reset by new tool activity and does not run while a tool call is still in progress.I tested it manually by: