docs: document the is_holdback flag for long-term holdbacks - #841
Open
yashikakhurana wants to merge 3 commits into
Open
yashikakhurana wants to merge 3 commits into
yashikakhurana wants to merge 3 commits into
Conversation
Adds a Holdbacks page under Experiment Workflow > Designing covering what the flag does, how the rolling analysis window is built, when the first results appear, and the cases where setting the flag has no effect. Also corrects the Jetstream configuration page, which recommended setting start_date and end_date by hand for holdbacks. That is what the flag replaces, and a value there overrides what Experimenter sends.
A custom enrollment query does not interfere with the flag, per review on metric-hub#1685; only enrollment_period and end_date override what Experimenter sends. Softened that bullet from a prohibition to a note about the cohort staying fixed if the query hard-codes a date range. Adds a section stating the flag is analysis-side only, which is the question owners have asked most, and a note that seeing effects change over time still needs a manual analysis.
yashikakhurana
requested review from
freshstrangemusic,
jaredlockhart and
mikewilli
as code owners
September 25, 2026 21:52
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a Holdbacks page under Experiment Workflow > Designing, covering the
is_holdbackflag: what it does, how the rolling analysis window is built, when the first results appear, and the cases where setting the flag has no effect.