Make source-test-doc-upload tasks check both issues and upload files.#3504
Open
Standard8 wants to merge 1 commit into
Open
Make source-test-doc-upload tasks check both issues and upload files.#3504Standard8 wants to merge 1 commit into
Standard8 wants to merge 1 commit into
Conversation
Member
Author
|
Just to be clear, the unit test is failing because #3488 needs merging first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
source-test-doc-uploadbuilders are now publishing anissues.jsonartifact, soDefaultTaskis being run to process the issues, however, this means that theDocUploadTaskis no longer being run, so reviews don't get the links to the documents.PR #3488 partially addresses this by making sure the
DocUploadTaskruns, but then theDefaultTaskwon't be run - so we'll revert to the previous state of uploading files, but not showing the details of an published issues.This PR builds on top of #3488 (both are needed), and changes the
DocUploadTaskto inherit fromDefaultTask, so that we'll check both the issues and upload the files if possible.I went with the inheritance approach, as this seemed better than spawning multiple tasks.