Skip to content

task type selector: set DefaultTask as last pick #3488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Archaeopteryx wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −3
Open

task type selector: set DefaultTask as last pick #3488

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions bot/code_review_bot/workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -691,9 +691,7 @@ def build_task(self, task_status):
raise Exception(f"Cannot read task name {task_id}")

# Default format is used first when the correct artifact is available

@La0 La0 Jul 10, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Default format is used first when the correct artifact is available
# Specific tasks detections are enabled first, default format is used as a fallback

if DefaultTask.matches(task_id):
return DefaultTask(task_id, task_status)
elif name.startswith("source-test-mozlint-"):
if name.startswith("source-test-mozlint-"):
return MozLintTask(task_id, task_status)
elif name == "source-test-clang-tidy":
return ClangTidyTask(task_id, task_status)
Expand All @@ -705,6 +703,8 @@ def build_task(self, task_status):
return ExternalTidyTask(task_id, task_status)
elif name == "source-test-taskgraph-diff":
return TaskGraphDiffTask(task_id, task_status)
elif DefaultTask.matches(task_id):
return DefaultTask(task_id, task_status)

def update_status(self, revision, state):
"""
Expand Down