Skip to content

Bug 2064523 - Bump mermaid from 10.9.8 to 12.2.0 - #2782

Merged
dklawren merged 4 commits into
mozilla:masterfrom
dklawren:2064523
Oct 16, 2026
Merged

dklawren merged 4 commits into
mozilla:masterfrom
dklawren:2064523

Conversation

@dklawren

Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Mermaid 12 requires Node 22.12+, while the asset build still uses Node 20.

0 open findings

What changed in this PR

Upgrades Mermaid from 10.9.8 to 12.2.0 and refreshes its dependency tree.

Changes:

  • Bumps Mermaid and transitive dependencies.
  • Updates guidance for future Mermaid major upgrades.
File Description
README.rst Updates upgrade guidance.
package.json Pins Mermaid 12.2.0.
package-lock.json Refreshes Mermaid’s dependency tree.
.github/​dependabot.yml Defers Mermaid 13.x updates.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Mermaid 12.2.0 has not yet satisfied the repository’s seven-day dependency cooldown.

0 open findings

Previously missed (1)

In code that hasn't changed since last review

Medium severity Defer Mermaid 12.2.0 bump until dependency cooldown expires

package.json:19

Mermaid 12.2.0 was published on 2026-10-13, only one day before this review. That bypasses the repository's seven-day dependency cooldown in .github/dependabot.yml:11-14, whose stated purpose is to avoid releases that are yanked or immediately patched. Please defer this bump until the cooldown expires, or use an eligible 12.x release and regenerate the lockfile.

🧠 Review effort: Balanced

@dklawren

Copy link
Copy Markdown
Collaborator Author

🔵 Needs a closer look

Mermaid 12.2.0 has not yet satisfied the repository’s seven-day dependency cooldown.

0 open findings
Previously missed (1)

🧠 Review effort: Balanced

This is a deliberate manual bump, so the cooldown doesn't apply. cooldown.default-days only delays the PRs Dependabot opens itself.

I looked at pinning to 12.1.0 (12 days old) to stay within the cooldown. The catch is that 12.1.0 depends on katex ^0.16.47, and that brings back GHSA-238p-pmpm-9mq7, which affects katex below 0.18.2. 12.2.0 moves katex to 0.18.x and npm audit comes back clean. The one 12.1.0 regression fixed in 12.2.0 (#8395) is ELK-only, and the dependency graph uses dagre, so the downgrade would gain us nothing. Keeping 12.2.0.

@dklawren
dklawren requested a review from cgsheeh October 14, 2026 20:04
Comment thread package.json
@dklawren
dklawren merged commit acc59d7 into mozilla:master Oct 16, 2026
7 of 8 checks passed
@dklawren
dklawren deleted the 2064523 branch October 16, 2026 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants