Repository navigation
Bug 2081207 - Add a Crash Data URL field for the graph and table - #2778
Merged
Merged
Conversation
Use cf_crash_data_url for Socorro filters in both widgets, replacing bug_file_loc as the table's filter source. Require the Socorro search URL prefix and a nonempty crash signature. Use MEDIUMTEXT for long URLs.
There was a problem hiding this comment.
🟡 Changes recommended
The classic bug view silently omits Crash Data URL filters from the crash table.
1 open finding
What changed in this PR
Adds a validated Crash Data URL field and applies its Socorro filters to crash widgets.
Changes:
- Adds field creation, visibility, validation, and error handling.
- Integrates URL filters into the crash graph and table.
- Adds REST and rendering regression coverage.
| File | Description |
|---|---|
qa/t/rest_bug_crash_data_url.t |
Tests validation and rendering. |
extensions/BugModal/template/en/default/bug_modal/edit.html.tmpl |
Moves URL into Crash Data. |
extensions/BugModal/template/en/default/bug_modal/create.html.tmpl |
Handles URL during creation. |
extensions/BMO/web/socorro-lens/main.js |
Applies URL filters to graphs. |
extensions/BMO/web/js/firefox-crash-table.js |
Applies URL filters to tables. |
extensions/BMO/template/en/default/hook/global/user-error-errors.html.tmpl |
Adds validation errors. |
extensions/BMO/template/en/default/hook/bug_modal/edit-custom_field-cf_crash_signature.html.tmpl |
Renders URL and graph. |
extensions/BMO/lib/Data.pm |
Configures field visibility. |
extensions/BMO/Extension.pm |
Creates and validates the field. |
Bugzilla/Template.pm |
Passes URL to Socorro Lens. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Collaborator
|
I will need to run checksetup.pl on the server once the new code is deployed to add the new custom field. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use cf_crash_data_url for Socorro filters in both widgets, replacing bug_file_loc as the table's filter source. Require the Socorro search URL prefix and a nonempty crash signature. Use MEDIUMTEXT for long URLs.