ctap2: serialize hmac-secret pinUvAuthProtocol without PUAT - #364
Open
iiTONELOC wants to merge 1 commit into
Open
ctap2: serialize hmac-secret pinUvAuthProtocol without PUAT#364iiTONELOC wants to merge 1 commit into
iiTONELOC wants to merge 1 commit into
Conversation
iiTONELOC
changed the title
micolous
reviewed
Aug 11, 2026
| &mut self, | ||
| secret: &SharedSecret, | ||
| puat: Option<&PinUvAuthToken>, | ||
| _puat: Option<&PinUvAuthToken>, |
Contributor
There was a problem hiding this comment.
While this may be a public API change, I think this parameter should be removed rather than ignored, because the spec doesn't mention anything about PUAT with hmac-secret.
However, it needs analysis on where this value is set to Some.
| self.pin_protocol = puat | ||
| .map(|puat| puat.pin_protocol.id()) | ||
| .filter(|id| *id != 1); | ||
| self.pin_protocol = Some(secret.pin_protocol.id()).filter(|id| *id != 1); |
Contributor
There was a problem hiding this comment.
While this field is optional in the spec, I don't think there's a reason to exclude it if using pinUvAuthProtocol = 1, as it makes this more complicated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CTAP 2.1 section 12.5 requires hmac-secret key 4 when the negotiated shared secret uses
pinUvAuthProtocol != 1.Currently, key 4 is derived from the optional PIN/UV auth token (PUAT), causing protocol-2 requests without PUAT to be interpreted as protocol 1 or rejected with
CTAP2_ERR_PIN_AUTH_INVALID.This change derives the protocol from the negotiated
SharedSecretwhile preserving omission for protocol 1.Tested with
cargo test --features crypto_rust --no-default-features.