Bug 2037926 - generate file-specific version_bump scopes for landoscript#215
Open
JohanLorenzo wants to merge 1 commit into
Open
Bug 2037926 - generate file-specific version_bump scopes for landoscript#215JohanLorenzo wants to merge 1 commit into
JohanLorenzo wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #215 +/- ##
==========================================
+ Coverage 98.38% 98.39% +0.01%
==========================================
Files 10 10
Lines 495 499 +4
Branches 86 87 +1
==========================================
+ Hits 487 491 +4
Misses 2 2
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bhearsum
approved these changes
May 26, 2026
bhearsum
left a comment
Contributor
There was a problem hiding this comment.
Seems fine. I want to call out that there's a possibility that this (or another patch) may cause complications on esr115 when you backport. If it does, I suggest hacking around it in that repository rather than trying to support the now-deprecated version_bump scope for the lifetime of esr115.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build_lando_payload: replacesproject:releng:lando:action:version_bumpwithproject:releng:lando:action:version_bump:file:<path>for each file inbump-filestest_lando_version_bumpto expect the new file-specific scope formatMerge order
version_bumpgrantsvalidate_scopesVerification
All 69 unit tests pass:
Taskgraph validation in xpi-manifest (using
--with-editable) confirms theversion-bump-newtabtask scopes are now:Bug 2037926