Don't EACS the macOS 26 minis mid-task: know the 2600 pool, fail closed - #80
Merged
Merged
Conversation
macmini-m4-130/131 run the gecko_t_osx_1500_m4 role but register in gecko-t-osx-2600-m4, which candidate_pools() didn't list. resolve() therefore called them unregistered, and for an unregistered host the reprovision flow skips quarantine and drain; step_wipe's busy check then asked the 1500 pool, whose 404 is_currently_busy reads as idle. A Hangar reprovision of either host could have wiped it mid-task. - A role now maps to every prod pool it can be registered in (primary last, so the fallback is unchanged); gecko_t_osx_1500_m4 includes 2600-m4. - step_wipe refuses an unregistered host if generic-worker is running on it, or if that can't be checked: a live worker means it IS registered, in a pool the orchestrator doesn't know. A genuinely fresh host still wipes. Verified live (read-only resolve): main -> m4-130 registered=False; this branch -> registered in gecko-t-osx-2600-m4; m4-112 / m4-80 unchanged. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug
macmini-m4-130 and m4-131 (macOS 26) run the
gecko_t_osx_1500_m4role but register ingecko-t-osx-2600-m4.candidate_pools()only listed the 1500 pools, so for these hosts:resolve()found them in no pool and setregistered=False.step_wipe's busy gate then asked the 1500 pool, andis_currently_busytreats that 404 as idle.A Hangar reprovision of either host could EACS it mid-task. It's the same failure mode as the 2026-07-10 incident, reached by a different route. Found while probing m4-130 for RELOPS-2454, when a quarantine 404'd.
The fix: two layers
gecko_t_osx_1500_m4→2600-m4,1500-m4, plus their-stagingvariants, probed staging first.step_wipenow runspgrepfor generic-worker and refuses to wipe if it's running, because a live worker means it is registered in a pool this map is missing. It also refuses if the check itself fails. A genuinely fresh host has no generic-worker, so it still wipes.Tests
5 new tests, and 291 pass with
opstripped from PATH; ruff is clean.1500-m4as the fallbackresolve()finds a macOS 26 host in 2600Mutation-checked: dropping the 2600 pool fails 2 tests, and disabling the gate fails 2.
Verified live (read-only
resolve())registered=False, pool 1500-m4registered=True, pool 2600-m4🤖 Generated with Claude Code