Conversation
Contributor
|
View this pull request in Lando to land it once approved. |
|
No new issues detected. This pull request is 🆗 |
pollym
force-pushed
the
remove-mockk-from-ui-tests
branch
from
September 25, 2026 09:19
0a17cc0 to
7369693
Compare
Mockk only runs on debuggable builds. - OnboardingMapperTest: luckily, in this case, a fake is easily substituted - CrashPullDelegateTest: lazy init means we don't need mocks or fakes 🎉
pollym
force-pushed
the
remove-mockk-from-ui-tests
branch
from
September 25, 2026 13:33
7369693 to
12bf3a5
Compare
|
Pull request closed by commit a82944e |
lando-worker Bot
pushed a commit
that referenced
this pull request
Sep 25, 2026
… r=mcarare Mockk only runs on debuggable builds. And we have an aspiration to run the ui tests on the nightly build. So a bit of refactoring is needed. (This is just a couple of the changes that will be required! more to follow) - `OnboardingMapperTest`: luckily, in this case, a fake is easily substituted - `CrashPullDelegateTest`: lazy init means we don't need mocks or fakes 🎉 [try is running here](https://treeherder.mozilla.org/jobs?repo=try&landoInstance=lando-prod-2025&landoCommitID=97406) Pull request: #368
|
No new issues detected. This pull request is 🆗 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mockk only runs on debuggable builds. And we have an aspiration to run the ui tests on the nightly build. So a bit of refactoring is needed. (This is just a couple of the changes that will be required! more to follow)
OnboardingMapperTest: luckily, in this case, a fake is easily substitutedCrashPullDelegateTest: lazy init means we don't need mocks or fakes 🎉try is running here
Lando: link
Bugzilla: bug 2073095
🚫 This pull request has 2 blockers.