Conversation
Contributor
|
View this pull request in Lando to land it once approved. |
|
No new issues detected. This pull request is 🆗 |
emilio
force-pushed
the
final-uri-quirk
branch
from
September 10, 2026 12:14
2a16539 to
38b35f4
Compare
This fixes the Firefox failures in web-platform-tests/wpt#62516. Implement it behind a pref just-in case. Also, unfortunately we need to do the same-origin check up-front, because the mime type check can happen off the main thread.
emilio
force-pushed
the
final-uri-quirk
branch
from
September 10, 2026 12:14
38b35f4 to
376fad6
Compare
dshin-moz
reviewed
Sep 10, 2026
|
|
||
| // Whether our final URI is same-origin with the document that's loading us. | ||
| // Only relevant for non-inline sheets. | ||
| bool mFinalURISameOrigin : 1 = false; |
Contributor
There was a problem hiding this comment.
This is new - rest are reordered (And compacted)
dshin-moz
reviewed
Sep 10, 2026
| } | ||
| if (StaticPrefs::layout_css_quirks_final_uri_check() && | ||
| !mFinalURISameOrigin) { | ||
| return false; |
Contributor
There was a problem hiding this comment.
Mostly reordering for readability, except for this check being added
dshin-moz
approved these changes
Sep 10, 2026
|
No new issues detected. This pull request is 🆗 |
lando-worker Bot
pushed a commit
that referenced
this pull request
Sep 10, 2026
This fixes the Firefox failures in web-platform-tests/wpt#62516. Implement it behind a pref just-in case. Also, unfortunately we need to do the same-origin check up-front, because the mime type check can happen off the main thread. Pull request: #364
|
Pull request closed by commit 6d5a2bb |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the Firefox failures in web-platform-tests/wpt#62516.
Implement it behind a pref just-in case. Also, unfortunately we need to
do the same-origin check up-front, because the mime type check can
happen off the main thread.
Lando: link
Bugzilla: bug 2070130
🚫 This pull request has 1 blocker.