Conversation
…ng. r=#layout If a fallback used to fit, but after fallback none of the positions fit, we end up in the base position, but we didn't clear the last index properly, so the fallback reflow kept triggering. Move the clear to after the loop, and add a test that repros with or without overlay scrollbars. Add also the test as a crashtest.
Contributor
|
View this pull request in Lando to land it once approved. |
dshin-moz
approved these changes
Sep 9, 2026
lando-worker Bot
pushed a commit
that referenced
this pull request
Sep 9, 2026
…ng. r=dshin If a fallback used to fit, but after fallback none of the positions fit, we end up in the base position, but we didn't clear the last index properly, so the fallback reflow kept triggering. Move the clear to after the loop, and add a test that repros with or without overlay scrollbars. Add also the test as a crashtest. Pull request: #362
|
Pull request closed by commit c70773c |
|
No new issues detected. This pull request is 🆗 |
moz-wptsync-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Sep 10, 2026
If a fallback used to fit, but after fallback none of the positions fit, we end up in the base position, but we didn't clear the last index properly, so the fallback reflow kept triggering. Move the clear to after the loop, and add a test that repros with or without overlay scrollbars. Add also the test as a crashtest. Pull request: mozilla-firefox/firefox#362 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=2070171 gecko-commit: 5868bfa1a7ba3fb5628c88e7767f5557284d6251 gecko-commit-git: c70773c3342a4e27f57a4ce8c05f49eecc9b8bf1 gecko-reviewers: dshin
lando-worker Bot
pushed a commit
that referenced
this pull request
Sep 16, 2026
…ng. a=pascalc DONTBUILD If a fallback used to fit, but after fallback none of the positions fit, we end up in the base position, but we didn't clear the last index properly, so the fallback reflow kept triggering. Move the clear to after the loop, and add a test that repros with or without overlay scrollbars. Add also the test as a crashtest. Pull request: #362 Differential Revision: https://phabricator.services.mozilla.com/D324999
lando-worker Bot
pushed a commit
that referenced
this pull request
Sep 18, 2026
…ng. a=dmeehan DONTBUILD If a fallback used to fit, but after fallback none of the positions fit, we end up in the base position, but we didn't clear the last index properly, so the fallback reflow kept triggering. Move the clear to after the loop, and add a test that repros with or without overlay scrollbars. Add also the test as a crashtest. Pull request: #362 Differential Revision: https://phabricator.services.mozilla.com/D324890
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a fallback used to fit, but after fallback none of the positions fit,
we end up in the base position, but we didn't clear the last index
properly, so the fallback reflow kept triggering.
Move the clear to after the loop, and add a test that repros with or
without overlay scrollbars. Add also the test as a crashtest.
Lando: link
Bugzilla: bug 2070171
🚫 This pull request has 1 blocker.