Conversation
…ptimization. r=#style We're hitting the "used cached reset properties" path, and thus we don't notice that .item indeed sets border-color, which is a visited dependent property. So we end up incorrectly with `border-color: currentcolor` in the computed style, and thus wrong rendering. Track the "used visited dependent properties" with a style bit and carry that around instead.
Contributor
|
View this pull request in Lando to land it once approved. |
dshin-moz
reviewed
Sep 9, 2026
| ); | ||
|
|
||
| using_cached_reset_properties = | ||
| cascade.try_to_use_cached_reset_properties(&mut context, rule_cache, guards); |
Contributor
There was a problem hiding this comment.
using cached reset props here
dshin-moz
reviewed
Sep 9, 2026
| cascade.try_to_use_cached_reset_properties(&mut context, rule_cache, guards); | ||
|
|
||
| if using_cached_reset_properties { | ||
| LonghandIdSet::late_group_only_inherited() |
Contributor
There was a problem hiding this comment.
border properties aren't inherited, so excluded from here
dshin-moz
reviewed
Sep 9, 2026
| // visited-dependent properties, we can avoid gathering the declarations, we know none | ||
| // would be relevant. | ||
| if unvisited_context.builder.rules.as_ref() != Some(rules) | ||
| || unvisited_properties.contains_any(visited_dependent_props) |
Contributor
There was a problem hiding this comment.
border-color never gets seen here, so we skip over this
dshin-moz
approved these changes
Sep 9, 2026
|
No new issues detected. This pull request is 🆗 |
|
Pull request closed by commit 8c2245f |
lando-worker Bot
pushed a commit
that referenced
this pull request
Sep 9, 2026
…ptimization. r=dshin We're hitting the "used cached reset properties" path, and thus we don't notice that .item indeed sets border-color, which is a visited dependent property. So we end up incorrectly with `border-color: currentcolor` in the computed style, and thus wrong rendering. Track the "used visited dependent properties" with a style bit and carry that around instead. Pull request: #360
github-actions Bot
pushed a commit
to DioxusLabs/stylo
that referenced
this pull request
Sep 10, 2026
…ptimization. r=dshin We're hitting the "used cached reset properties" path, and thus we don't notice that .item indeed sets border-color, which is a visited dependent property. So we end up incorrectly with `border-color: currentcolor` in the computed style, and thus wrong rendering. Track the "used visited dependent properties" with a style bit and carry that around instead. Pull request: mozilla-firefox/firefox#360
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're hitting the "used cached reset properties" path, and thus we don't
notice that .item indeed sets border-color, which is a visited dependent
property. So we end up incorrectly with
border-color: currentcolorinthe computed style, and thus wrong rendering.
Track the "used visited dependent properties" with a style bit and carry
that around instead.
Lando: link
Bugzilla: bug 2070311
🚫 This pull request has 1 blocker.